Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DueDateTimeChecker may be scheduled with a negative delay #9236

Closed
pihme opened this issue Apr 27, 2022 · 0 comments · Fixed by #9237
Closed

DueDateTimeChecker may be scheduled with a negative delay #9236

pihme opened this issue Apr 27, 2022 · 0 comments · Fixed by #9237
Assignees
@saig0 @pihme
Labels
area/reliability Marks an issue as related to improving the reliability of our software (i.e. it behaves as expected) kind/bug Categorizes an issue or PR as a bug scope/broker Marks an issue or PR to appear in the broker section of the changelog severity/high Marks a bug as having a noticeable impact on the user with no known workaround version:1.3.8 version:8.1.0-alpha1 Marks an issue as being completely or in parts released in 8.1.0-alpha1 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0

Comments

@pihme
Copy link
Contributor

pihme commented Apr 27, 2022

Describe the bug

The class DueDateTimeChecker may be scheduled with a negative delay. In this case it will run pretty much immediately. This leaves little time for other processing to take place.

Related to #8991
@pihme pihme added the kind/bug Categorizes an issue or PR as a bug label Apr 27, 2022
@pihme pihme mentioned this issue Apr 27, 2022
Open
@pihme pihme assigned pihme and saig0 Apr 27, 2022
@pihme pihme mentioned this issue Apr 27, 2022
Merged
10 tasks
@npepinpe npepinpe added area/reliability Marks an issue as related to improving the reliability of our software (i.e. it behaves as expected) severity/high Marks a bug as having a noticeable impact on the user with no known workaround scope/broker Marks an issue or PR to appear in the broker section of the changelog team/process-automation labels Apr 27, 2022
zeebe-bors-camunda bot added a commit that referenced this issue Apr 29, 2022
@zeebe-bors-camunda @pihme
merge: #9237
890a33e 
9237: refactor(engine): prevent instant rescheduling r=pihme a=pihme

## Description

Before this change, the delay calculated to reschedule a task could be negative or close to 0.
This lead to the checker being immediately rescheduled. This is bad, because it does not leave room
for other tasks to run.

With this change, a lower floor is applied when the task is rescheduled.

## Related issues

closes #9236 
preparation for #9238  

<!---
## Definition of Ready

* [X] I've reviewed my own code
* [X] I've written a clear changelist description
* [X] I've narrowly scoped my changes
* [X] I've separated structural from behavioural changes
-->

## Definition of Done
Code changes:
* [X] The changes are backwards compatibility with previous versions
* [ ] If it fixes a bug then PRs are created to [backport](https://github.com/camunda/zeebe/compare/stable/0.24...main?expand=1&template=backport_template.md&title=[Backport%200.24]) the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. `backport stable/1.3`) to the PR, in case that fails you need to create backports manually.

Testing:
* [ ] There are unit/integration tests that verify all acceptance criterias of the issue
* [ ] New tests are written to ensure backwards compatibility with further versions
* [ ] The behavior is tested manually
* [ ] The change has been verified by a QA run
* [ ] The impact of the changes is verified by a benchmark

Documentation:
* [ ] The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
* [ ] New content is added to the [release announcement](https://drive.google.com/drive/u/0/folders/1DTIeswnEEq-NggJ25rm2BsDjcCQpDape)
* [ ] If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Please refer to our [review guidelines](https://github.com/camunda/zeebe/wiki/Pull-Requests-and-Code-Reviews#code-review-guidelines).


Co-authored-by: pihme <pihme@users.noreply.github.com>
This was referenced Apr 29, 2022
Merged
Merged
zeebe-bors-camunda bot added a commit that referenced this issue Apr 29, 2022
@zeebe-bors-camunda @pihme
merge: #9255
79d905c 
9255: [Backport stable/1.3] refactor(engine): prevent instant rescheduling r=pihme a=github-actions[bot]

# Description
Backport of #9237 to `stable/1.3`.

relates to #9236 #9238

Co-authored-by: pihme <pihme@users.noreply.github.com>
zeebe-bors-camunda bot added a commit that referenced this issue Apr 29, 2022
@zeebe-bors-camunda @pihme
merge: #9256
d91a276 
9256: [Backport stable/8.0] refactor(engine): prevent instant rescheduling r=pihme a=github-actions[bot]

# Description
Backport of #9237 to `stable/8.0`.

relates to #9236 #9238

Co-authored-by: pihme <pihme@users.noreply.github.com>
@deepthidevaki deepthidevaki added the version:8.1.0-alpha1 Marks an issue as being completely or in parts released in 8.1.0-alpha1 label May 3, 2022
@Zelldon Zelldon added the version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0 label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@saig0 saig0

@pihme pihme

Labels
area/reliability Marks an issue as related to improving the reliability of our software (i.e. it behaves as expected) kind/bug Categorizes an issue or PR as a bug scope/broker Marks an issue or PR to appear in the broker section of the changelog severity/high Marks a bug as having a noticeable impact on the user with no known workaround version:1.3.8 version:8.1.0-alpha1 Marks an issue as being completely or in parts released in 8.1.0-alpha1 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(engine): prevent instant rescheduling camunda/zeebe
5 participants
@npepinpe @deepthidevaki @Zelldon @saig0 @pihme