Dead code in metrics exporter #9760
Comments
korthout
added
kind/toil
Zelldon
added
component/exporter
area/observability
|
I think we can close this now. |
|
The same code is still there: and can still not be reached due to: It looks to me like a cleanup or potential performance optimization to immediately advance the exporter position after ignoring a record and allowing for log compaction. On the other hand, such a behavior should be part of the generic I am also asking to generally understand best practices for writing exporters. Should all exporters have this cleanup even if they use record filters? Or is it enough to rely on events occurring sufficiently frequent even in case the |
|
No, this is likely an artifact from before we had record filters 👍 I'll remove it. That said, I would expect the JVM to eventually optimize this code and make this almost a noop. As best practice, always use record filter, as it may allow us to skip a record entirely without reading it. |
## Description Removes an unnecessary condition to exit early if the record is not event. This is unnecessary because we're already applying a record filter for the exporter which only accepts events. ## Related issues closes #9760
After @korthout added a
RecordFilterin db64a95 the following code block should be dead code because no other record types would arrive in the exporterhttps://github.com/camunda/zeebe/blob/2c52c6a764ed6d9bcc19428d9a2592a3888ed741/broker/src/main/java/io/camunda/zeebe/broker/exporter/metrics/MetricsExporter.java#L92
The text was updated successfully, but these errors were encountered: