Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

As a user I want to configure LongPollingActivateJobsHandler #8777

Closed
aivinog1 opened this issue Feb 12, 2022 · 4 comments · Fixed by #18432
Closed

As a user I want to configure LongPollingActivateJobsHandler #8777

aivinog1 opened this issue Feb 12, 2022 · 4 comments · Fixed by #18432
Labels
component/gateway component/zeebe Related to the Zeebe component/team good first issue Marks an issue as simple enough for first time contributors kind/feature Categorizes an issue or PR as a feature, i.e. new behavior

Comments

@aivinog1
Copy link
Contributor

Is your feature request related to a problem? Please describe.
It would be nice to have the ability to customize LongPollingActivateJobsHandler. Like timeouts, minimal empty responses, etc.

Describe the solution you'd like
I think that these settings should be added via Spring Boot configuration and environment variables.

Describe alternatives you've considered
Maybe these should be configured via environment variables or Spring Boot configuration.

Additional context
You can find the source of this issue here: https://camunda-cloud.slack.com/archives/C6WGNHV2A/p1644477175720079
@aivinog1 aivinog1 added the kind/feature Categorizes an issue or PR as a feature, i.e. new behavior label Feb 12, 2022
@npepinpe npepinpe added the good first issue Marks an issue as simple enough for first time contributors label Feb 22, 2022
@npepinpe
Copy link
Member

Seems reasonable. These should indeed be done via the normal gateway configuration. There's already a LongPollingCfg, so we can piggyback on that. I don't think we will focus on this for now, but I'm happy to receive a PR for it.

@Abhi-vashisth
Copy link

hello is anyone assign to this issue or i can work on it

@aivinog1
Copy link
Contributor Author

aivinog1 commented Mar 1, 2022

Hey @Abhi-vashisth,

I'm already working on it, but feel free to provide your solution 🙂

@romansmirnov romansmirnov added the component/zeebe Related to the Zeebe component/team label Mar 5, 2024
@npepinpe
Copy link
Member

With job streaming making use of polling under the hood, increasing the long polling timeout becomes more and more useful to reduce the amount of unnecessary requests. So I would push a bit to allow at least configuring the timeout.

@EuroLew EuroLew mentioned this issue May 10, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue May 21, 2024
@EuroLew
Configure long polling activate jobs handler (#18432)
6ae2548 
## Description
Added Long polling configuration options and associated documentation.

## Related issues

closes #8777
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/gateway component/zeebe Related to the Zeebe component/team good first issue Marks an issue as simple enough for first time contributors kind/feature Categorizes an issue or PR as a feature, i.e. new behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Configure long polling activate jobs handler camunda/camunda
7 participants
@npepinpe @menski @romansmirnov @Zelldon @pihme @aivinog1 @Abhi-vashisth