Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport release-8.1.0] Migrate StreamProcessor test #10586

Merged
merged 6 commits into from Sep 30, 2022
Merged

[Backport release-8.1.0] Migrate StreamProcessor test #10586

merged 6 commits into from Sep 30, 2022

Conversation

backport-action
Copy link
Collaborator

Description

Backport of #10468 to release-8.1.0.

relates to #10455 #10455 #10458

@backport-action backport-action mentioned this pull request Sep 30, 2022
Merged
10 tasks
Zelldon
Zelldon approved these changes Sep 30, 2022
View reviewed changes
Copy link
Member

@Zelldon Zelldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@zeebe-bors-camunda
Copy link
Contributor

Merge conflict.

@Zelldon
test: introduce mock for lifecycle awareness
e4b1536 
(cherry picked from commit ae68802)
@Zelldon
refactor: rename default processor
16370e4 
Make clear that the default record processor is a mock and can be asserted/verified.

(cherry picked from commit b63c987)
@Zelldon
refactor: make mock a field
d1eb773 
This allows to stub calls before starting the processor

(cherry picked from commit 6858deb)
@Zelldon
test: migrate StreamProcessorTest
d5c5f2a 
Migrate the StreamProcessor to the new StreamProcessorExtension and
Junit5

Completelty iterated over all tests and rewrote them.

(cherry picked from commit c8ca2dc)
@Zelldon
test: remove old StreamProcessorTest
6181e7d 
(cherry picked from commit 3c64f41)
@Zelldon
style: apply codestyle
352e767 
(cherry picked from commit 3fbde5f)
@Zelldon Zelldon force-pushed the backport-10468-to-release-8.1.0 branch from 6146acc to 352e767 Compare September 30, 2022 13:10
@github-actions
Copy link
Contributor

github-actions bot commented Sep 30, 2022 •
edited

Test Results

   935 files  ±  0     935 suites  ±0   2h 11m 13s ⏱️ -42s
7 445 tests  - 37  7 437 ✔️  - 35  8 💤  - 2  0 ❌ ±0 
7 633 runs   - 37  7 625 ✔️  - 35  8 💤  - 2  0 ❌ ±0 

Results for commit 352e767. ± Comparison against base commit dea0635.

♻️ This comment has been updated with latest results.

@Zelldon
Copy link
Member

Zelldon commented Sep 30, 2022

bors r+

zeebe-bors-camunda bot added a commit that referenced this pull request Sep 30, 2022
@zeebe-bors-camunda @Zelldon
merge: #10586
b56275d 
10586: [Backport release-8.1.0] Migrate StreamProcessor test r=Zelldon a=backport-action

# Description
Backport of #10468 to `release-8.1.0`.

relates to #10455 #10455 #10458

Co-authored-by: Christopher Zell <zelldon91@googlemail.com>
@zeebe-bors-camunda
Copy link
Contributor

Build failed:

@Zelldon
Copy link
Member

Zelldon commented Sep 30, 2022

Still merging since I want to build the rc today and have to merge other stuff, only flakes were failing

@Zelldon Zelldon merged commit c7ff8cd into release-8.1.0 Sep 30, 2022
@Zelldon Zelldon deleted the backport-10468-to-release-8.1.0 branch September 30, 2022 13:29
@Zelldon Zelldon added the version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0 label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zelldon Zelldon Zelldon approved these changes

Assignees
No one assigned
Labels
version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@backport-action @Zelldon