[Backport release-8.1.0]: Remove actor#submit from ScheduleService #10584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
Sep 30, 2022
10584: [Backport release-8.1.0]: Remove actor#submit from ScheduleService r=oleschoenburg a=Zelldon ## Description Backports #10554 to the release branch, since I think it makes sense to have in the release as well. Afterwards I have to recreate the benchmarks and rerun the e2e tests. <!-- Please explain the changes you made here. --> I had to do cherry-pick manually since there were conflicts with the ProcessingScheduleServiceIntegrationTest (we delete them in this PR). No other commit was harmed. ## Related issues <!-- Which issues are closed by this PR or are related --> closes #10291 Co-authored-by: Christopher Zell <zelldon91@googlemail.com>
|
Build failed: |
|
bors r+ |
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
Sep 30, 2022
10584: [Backport release-8.1.0]: Remove actor#submit from ScheduleService r=Zelldon a=Zelldon ## Description Backports #10554 to the release branch, since I think it makes sense to have in the release as well. Afterwards I have to recreate the benchmarks and rerun the e2e tests. <!-- Please explain the changes you made here. --> I had to do cherry-pick manually since there were conflicts with the ProcessingScheduleServiceIntegrationTest (we delete them in this PR). No other commit was harmed. ## Related issues <!-- Which issues are closed by this PR or are related --> closes #10291 Co-authored-by: Christopher Zell <zelldon91@googlemail.com>
|
Build failed: |
Using an own executor avoids using the ProcessingScheduleService, which shouldn't be accessed from outside the Processing Actor. Furthermore, we reduce the access to the LogStream object from the Context.
Finally remove the LogStream from the API, which removed the last remaining LogStream knowledge from the engine/processing API
Zelldon
force-pushed
the
zell-bp-10554-for-10291
branch
from
54e2acb
to
1de79b6
Compare
|
I have rebased, there went something wrong with bors merge. |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backports #10554 to the release branch, since I think it makes sense to have in the release as well. Afterwards I have to recreate the benchmarks and rerun the e2e tests.
I had to do cherry-pick manually since there were conflicts with the ProcessingScheduleServiceIntegrationTest (we delete them in this PR). No other commit was harmed.
Related issues
closes #10291
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Please refer to our review guidelines.