Using modification, I can't activate an element if an interrupting event subprocess was triggered #10477
Assignees
Labels
area/reliability
Marks an issue as related to improving the reliability of our software (i.e. it behaves as expected)
area/ux
Marks an issue as related to improving the user experience
kind/bug
Categorizes an issue or PR as a bug
scope/broker
Marks an issue or PR to appear in the broker section of the changelog
severity/high
Marks a bug as having a noticeable impact on the user with no known workaround
version:8.1.1
Marks an issue as being completely or in parts released in 8.1.1
version:8.2.0-alpha1
Marks an issue as being completely or in parts released in 8.2.0-alpha1
version:8.2.0
Marks an issue as being completely or in parts released in 8.2.0
Comments
Root causingOn processing the modification command, we write an The modification works for a nested element because we create the flow scope of the element directly by writing an |
saig0
added
scope/broker
10 tasks
|
I've discussed how we could solve this with @saig0. The first question is whether we should allow this behavior at all. Using modification users could have an active element in the event subprocess as well as in the interrupted scope. This is something that would normally be impossible, yet it provides flexibility to users. I will check how this behaves in C7. If we allow this behavior we have to figure out a solution tot his problem. One proposal was simply removing the interrupted state of an element instance once an event subprocess is activated. This proofs troublesome in other parts of the code, as we have a bunch of checks whether an element instance is interrupted or not. Most of these checks would have to be changed when we go ahead with this solution. |
|
I have checked C7. It is allowed there. When an event subprocess is active and a task in an interrupted scope gets activated nothing gets rejected: |
zeebe-bors-camunda bot
added a commit
that referenced
this issue
Oct 10, 2022
10609: Remove interrupted state on event subprocess activation r=remcowesterhoud a=remcowesterhoud ## Description <!-- Please explain the changes you made here. --> When an interrupting event sub process gets triggered it will terminate all active element in its flow scope and mark the flow scope as interrupted. With process instance modification it should be possible to re-activate element within the interrupted scope. Because of the interrupted state any activate commands get rejected, making this currently impossible. With this change we will check if any of the activated elements is currently in an interrupted state. If this is the case we will remove this state, allowing elements within to be activated through a modification. ## Related issues <!-- Which issues are closed by this PR or are related --> closes #10477 10649: deps(maven): bump aws-java-sdk-core from 1.12.318 to 1.12.319 r=oleschoenburg a=dependabot[bot] Bumps [aws-java-sdk-core](https://github.com/aws/aws-sdk-java) from 1.12.318 to 1.12.319. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/aws/aws-sdk-java/blob/master/CHANGELOG.md">aws-java-sdk-core's changelog</a>.</em></p> <blockquote> <h1><strong>1.12.319</strong> <strong>2022-10-07</strong></h1> <h2><strong>AWS IoT Greengrass V2</strong></h2> <ul> <li> <h3>Features</h3> <ul> <li>This release adds error status details for deployments and components that failed on a device and adds features to improve visibility into component installation.</li> </ul> </li> </ul> <h2><strong>Amazon CodeGuru Reviewer</strong></h2> <ul> <li> <h3>Features</h3> <ul> <li>Documentation update to replace broken link.</li> </ul> </li> </ul> <h2><strong>Amazon QuickSight</strong></h2> <ul> <li> <h3>Features</h3> <ul> <li>Amazon QuickSight now supports SecretsManager Secret ARN in place of CredentialPair for DataSource creation and update. This release also has some minor documentation updates and removes CountryCode as a required parameter in GeoSpatialColumnGroup</li> </ul> </li> </ul> <h2><strong>Elastic Load Balancing</strong></h2> <ul> <li> <h3>Features</h3> <ul> <li>Gateway Load Balancer adds a new feature (target_failover) for customers to rebalance existing flows to a healthy target after marked unhealthy or deregistered. This allows graceful patching/upgrades of target appliances during maintenance windows, and helps reduce unhealthy target failover time.</li> </ul> </li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/aws/aws-sdk-java/commit/e752d66f73b94f4c54d995b6bde56301ade507af"><code>e752d66</code></a> AWS SDK for Java 1.12.319</li> <li><a href="https://github.com/aws/aws-sdk-java/commit/e176eb25613173ac59301716281018a837654589"><code>e176eb2</code></a> Update GitHub version number to 1.12.319-SNAPSHOT</li> <li>See full diff in <a href="https://github.com/aws/aws-sdk-java/compare/1.12.318...1.12.319">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting ``@dependabot` rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - ``@dependabot` rebase` will rebase this PR - ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it - ``@dependabot` merge` will merge this PR after your CI passes on it - ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it - ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging - ``@dependabot` reopen` will reopen this PR if it is closed - ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Co-authored-by: Remco Westerhoud <remco@westerhoud.nl> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
zeebe-bors-camunda bot
added a commit
that referenced
this issue
Oct 10, 2022
10609: Remove interrupted state on event subprocess activation r=remcowesterhoud a=remcowesterhoud ## Description <!-- Please explain the changes you made here. --> When an interrupting event sub process gets triggered it will terminate all active element in its flow scope and mark the flow scope as interrupted. With process instance modification it should be possible to re-activate element within the interrupted scope. Because of the interrupted state any activate commands get rejected, making this currently impossible. With this change we will check if any of the activated elements is currently in an interrupted state. If this is the case we will remove this state, allowing elements within to be activated through a modification. ## Related issues <!-- Which issues are closed by this PR or are related --> closes #10477 Co-authored-by: Remco Westerhoud <remco@westerhoud.nl>
zeebe-bors-camunda bot
added a commit
that referenced
this issue
Oct 10, 2022
10609: Remove interrupted state on event subprocess activation r=remcowesterhoud a=remcowesterhoud ## Description <!-- Please explain the changes you made here. --> When an interrupting event sub process gets triggered it will terminate all active element in its flow scope and mark the flow scope as interrupted. With process instance modification it should be possible to re-activate element within the interrupted scope. Because of the interrupted state any activate commands get rejected, making this currently impossible. With this change we will check if any of the activated elements is currently in an interrupted state. If this is the case we will remove this state, allowing elements within to be activated through a modification. ## Related issues <!-- Which issues are closed by this PR or are related --> closes #10477 10618: feat(engine): Apply output mappings for none end events r=remcowesterhoud a=skayliu ## Description <!-- Please explain the changes you made here. --> Support none end event outputs. ## Related issues <!-- Which issues are closed by this PR or are related --> closes #10613 10629: test(qa): verify backup when partition is replicated r=deepthidevaki a=deepthidevaki ## Description - Verify backup when the partition is replicated. ## Related issues closes #10387 10649: deps(maven): bump aws-java-sdk-core from 1.12.318 to 1.12.319 r=oleschoenburg a=dependabot[bot] Bumps [aws-java-sdk-core](https://github.com/aws/aws-sdk-java) from 1.12.318 to 1.12.319. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/aws/aws-sdk-java/blob/master/CHANGELOG.md">aws-java-sdk-core's changelog</a>.</em></p> <blockquote> <h1><strong>1.12.319</strong> <strong>2022-10-07</strong></h1> <h2><strong>AWS IoT Greengrass V2</strong></h2> <ul> <li> <h3>Features</h3> <ul> <li>This release adds error status details for deployments and components that failed on a device and adds features to improve visibility into component installation.</li> </ul> </li> </ul> <h2><strong>Amazon CodeGuru Reviewer</strong></h2> <ul> <li> <h3>Features</h3> <ul> <li>Documentation update to replace broken link.</li> </ul> </li> </ul> <h2><strong>Amazon QuickSight</strong></h2> <ul> <li> <h3>Features</h3> <ul> <li>Amazon QuickSight now supports SecretsManager Secret ARN in place of CredentialPair for DataSource creation and update. This release also has some minor documentation updates and removes CountryCode as a required parameter in GeoSpatialColumnGroup</li> </ul> </li> </ul> <h2><strong>Elastic Load Balancing</strong></h2> <ul> <li> <h3>Features</h3> <ul> <li>Gateway Load Balancer adds a new feature (target_failover) for customers to rebalance existing flows to a healthy target after marked unhealthy or deregistered. This allows graceful patching/upgrades of target appliances during maintenance windows, and helps reduce unhealthy target failover time.</li> </ul> </li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/aws/aws-sdk-java/commit/e752d66f73b94f4c54d995b6bde56301ade507af"><code>e752d66</code></a> AWS SDK for Java 1.12.319</li> <li><a href="https://github.com/aws/aws-sdk-java/commit/e176eb25613173ac59301716281018a837654589"><code>e176eb2</code></a> Update GitHub version number to 1.12.319-SNAPSHOT</li> <li>See full diff in <a href="https://github.com/aws/aws-sdk-java/compare/1.12.318...1.12.319">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting ``@dependabot` rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - ``@dependabot` rebase` will rebase this PR - ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it - ``@dependabot` merge` will merge this PR after your CI passes on it - ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it - ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging - ``@dependabot` reopen` will reopen this PR if it is closed - ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Co-authored-by: Remco Westerhoud <remco@westerhoud.nl> Co-authored-by: skayliu <skay463@163.com> Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
korthout
added
the
version:8.1.1
korthout
added
the
version:8.2.0-alpha1
npepinpe
added
the
version:8.2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The process instance modification doesn't work if an interrupting event subprocess was triggered.
I deployed a process with an interrupting event subprocess. I created an instance of the process. The interrupting event subprocess was triggered.
Now, I try to modify the process instance and activate an element that is in the same scope as the event subprocess (e.g. the subprocess that contains the task
C). The modification command is applied (i.e. no rejection) but the element is not activated.If I try to activate an element in a nested scope instead (e.g. the task
C) then it works and the element (e.g. taskC) and its flow scopes (e.g. the subprocess that containsC) are activated.To Reproduce
.bpmnfile extension)JUnit test
Expected behavior
Using the process instance modification, I can activate an element if an interrupting event subprocess was triggered in the same scope.
Log/Stacktrace
Test output
Environment:
8.1.0The text was updated successfully, but these errors were encountered: