Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ResultBuilder in Engine #10003

Closed
Zelldon opened this issue Aug 5, 2022 · 2 comments
Closed

Create ResultBuilder in Engine #10003

Zelldon opened this issue Aug 5, 2022 · 2 comments
Labels
kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc.

Comments

@Zelldon
Copy link
Member

Zelldon commented Aug 5, 2022

Description

blocked by #10001

After the BufferedProcessingResultBuilder is finalized and we can create the ResultBuilder without LogStream dependencies, that means we can create the Builder in the Engine implementation and remove it from the StreamProcessor.

This allows us to remove the builder from the RecordProcessor interface and return only the Result. This should simplify the interface.

related to #9998

@Zelldon Zelldon added the kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. label Aug 5, 2022
@megglos
Copy link
Contributor

megglos commented Sep 30, 2022

@Zelldon unblocked?

@Zelldon
Copy link
Member Author

Zelldon commented Sep 30, 2022

Actually we can close this issue. This is no longer possible it was not expected in august that we need it like it currently is.

Short Explanation:

The ProcessingStateMachine need to create the ResultBuilder and pass it to the RecordProcessor, because we need to make sure that it has the RecordBatch limit check ( which is based on the maxMessageSize). To hide that mostly from the Engine, we create the ResultBuilder here https://github.com/camunda/zeebe/blob/main/engine/src/main/java/io/camunda/zeebe/streamprocessor/ProcessingStateMachine.java#L246 and give it the RecordProcessor here https://github.com/camunda/zeebe/blob/main/engine/src/main/java/io/camunda/zeebe/streamprocessor/ProcessingStateMachine.java#L261

@Zelldon Zelldon closed this as completed Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc.
Projects
None yet
Development

No branches or pull requests

2 participants