merge: #9934

9934: Don't log JsonParseExceptions as errors r=remcowesterhoud a=remcowesterhoud

## Description
JsonParseExceptions get thrown when a user passes variables in their request which cannot be converted to message pack. Currently these are being logged as errors. Since this a fault by the user we should log these as debug.

<!-- Which issues are closed by this PR or are related -->

closes #9933



Co-authored-by: Remco Westerhoud <remco@westerhoud.nl>

gateway/src/main/java/io/camunda/zeebe/gateway/grpc/GrpcErrorMapper.java

@@ -7,6 +7,7 @@
  */
 package io.camunda.zeebe.gateway.grpc;
 
+import com.fasterxml.jackson.core.JsonParseException;
 import com.google.protobuf.Any;
 import com.google.rpc.Code;
 import com.google.rpc.Status;
@@ -72,6 +73,9 @@ private Status mapErrorToStatus(
       builder.setCode(Code.INVALID_ARGUMENT_VALUE).setMessage(error.getMessage());
       logger.debug(
           "Expected to handle gRPC request, but messagepack property was invalid", rootError);
+    } else if (error instanceof JsonParseException) {
+      builder.setCode(Code.INVALID_ARGUMENT_VALUE).setMessage(error.getMessage());
+      logger.debug("Expected to handle gRPC request, but JSON property was invalid", rootError);
     } else if (error instanceof PartitionNotFoundException) {
       builder.setCode(Code.UNAVAILABLE_VALUE).setMessage(error.getMessage());
       logger.debug(

gateway/src/test/java/io/camunda/zeebe/gateway/grpc/GrpcErrorMapperTest.java

@@ -8,12 +8,15 @@
 package io.camunda.zeebe.gateway.grpc;
 
 import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.fail;
 
+import com.fasterxml.jackson.core.JsonParseException;
 import com.google.protobuf.InvalidProtocolBufferException;
 import com.google.rpc.Status;
 import io.camunda.zeebe.gateway.cmd.BrokerErrorException;
 import io.camunda.zeebe.gateway.impl.broker.RequestRetriesExhaustedException;
 import io.camunda.zeebe.gateway.impl.broker.response.BrokerError;
+import io.camunda.zeebe.protocol.impl.encoding.MsgPackConverter;
 import io.camunda.zeebe.protocol.record.ErrorCode;
 import io.camunda.zeebe.util.logging.RecordingAppender;
 import io.grpc.Status.Code;
@@ -118,4 +121,26 @@ void shouldLogTimeoutExceptionWithCorrectStacktrace() {
 
     assertThat(event.getThrown()).isEqualTo(executionException);
   }
+
+  @Test
+  void shouldLogJsonParseExceptionOnDebug() {
+    // given
+    try {
+      MsgPackConverter.convertToMsgPack("{\"json\":\"invalid\"");
+      fail("Expected to throw exception");
+    } catch (final RuntimeException runtimeException) {
+      assertThat(runtimeException.getCause()).isInstanceOf(JsonParseException.class);
+      final JsonParseException exception = (JsonParseException) runtimeException.getCause();
+
+      // when
+      log.setLevel(Level.DEBUG);
+      final StatusRuntimeException statusException = errorMapper.mapError(exception, logger);
+
+      // then
+      assertThat(statusException.getStatus().getCode()).isEqualTo(Code.INVALID_ARGUMENT);
+      assertThat(recorder.getAppendedEvents()).hasSize(1);
+      final LogEvent event = recorder.getAppendedEvents().get(0);
+      assertThat(event.getLevel()).isEqualTo(Level.DEBUG);
+    }
+  }
 }