Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create backup docs #3791

Merged
merged 7 commits into from
May 22, 2024
Merged

Create backup docs #3791

merged 7 commits into from
May 22, 2024

Conversation

akeller
Copy link
Member

@akeller akeller commented May 10, 2024 •
edited

Description

Closes #3684. This change should be backported.

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.

  • My changes are for the next minor and are in /docs directory (aka /next/).

  • I included my new page in the sidebar file(s).

@akeller akeller added component:docs Documentation improvements, including new or updated content component:console Issues related with Console project labels May 10, 2024
@akeller akeller self-assigned this May 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 10, 2024 •
edited

👋 🤖 ✅ Looks like the changes were ported across versions, nice job! 🎉

You can read more about the versioning within our docs in our documentation guidelines.

@akeller
Copy link
Member Author

akeller commented May 10, 2024 •
edited

Open questions:

  • Are backups an enterprise only features?
  • Is this also available in Console SM?
  • Are there any additional screenshots that should be included?

@akeller
Copy link
Member Author

akeller commented May 10, 2024

Reached out to ask-controller - https://camunda.slack.com/archives/C051AA63QV8/p1715364542060449

@sjiekak sjiekak self-requested a review May 17, 2024 08:03
sjiekak
sjiekak previously approved these changes May 17, 2024
View reviewed changes
Copy link

@sjiekak sjiekak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks

@akeller akeller marked this pull request as ready for review May 17, 2024 18:53
Sijoma
Sijoma reviewed May 21, 2024
View reviewed changes
Copy link
Contributor

@Sijoma Sijoma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for documenting this. I guess the one manual is too much after the merge.

docs/components/console/manage-clusters/cluster-backups.md Outdated Show resolved Hide resolved
@akeller akeller requested a review from Sijoma May 21, 2024 16:24
Sijoma
Sijoma approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@Sijoma Sijoma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

sjiekak
sjiekak approved these changes May 22, 2024
View reviewed changes
Copy link

@sjiekak sjiekak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@akeller akeller merged commit c2c7c24 into main May 22, 2024
7 checks passed
@akeller akeller deleted the create-backups branch May 22, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hisImminence hisImminence hisImminence left review comments

@sjiekak sjiekak sjiekak approved these changes

@Sijoma Sijoma Sijoma approved these changes

@christinaausley christinaausley Awaiting requested review from christinaausley

Assignees

@akeller akeller

Labels
component:console Issues related with Console project component:docs Documentation improvements, including new or updated content
Projects
Developer Experience
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cluster-creating-model includes option for backup location
5 participants
@akeller @sjiekak @Sijoma @hisImminence @christinaausley