New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make authentication provider a configuration option #439
Comments
Hi @datakurre , That sounds like a sensible feature request. Do you want to try to create pull request? To me that would have simpler than your replace logic 😀 Todo
|
@tobiasschaefer Thanks for those pointers! I’ll see later if I can do this 💪 Probably would have been faster to do the option in the first place 😅 |
…gurable, e.g. "com.example.camunda.JWTAuthenticationProvider"
…gurable, e.g. "com.example.camunda.JWTAuthenticationProvider"
…gurable, e.g. "com.example.camunda.JWTAuthenticationProvider"
Hey @datakurre , please try release 2.11.0 which has the option to configure the authentication-provider. see configuration option |
@tobiasschaefer Wow! Thanks. So good I used my time to debug long poll issue instead. Will update that issue with more details soon... |
Thanks. That's team work 😀 |
Confirm that this works. Although, one must both enable basic auth and define custom provider, but it is probably safer that way. |
…ation-provider no longer requires basic authentication to be enabled.
Hi @datakurre , good point! IMHO if someone (you 😀) configures a custom authentication provider he should know what he is doing. I don't see a reason why basic auth should be required since it would be used anyway. Correct? Does this PR look good to you? #448 |
…ger requires basic authentication to be enabled.
I wanted to customize authentication to support custom JWT authentication, and had to make a volt for something that could be a configurable string.
Authentication provider is configured at
micronaut-camunda-platform-7/micronaut-camunda-bpm-feature/src/main/java/info/novatec/micronaut/camunda/bpm/feature/rest/JettyServerCustomizerRuntimeRest.java
Line 86 in 94e1b40
Overriding that was possible https://github.com/datakurre/collective.bpmproxy/blob/dd97b4f733fdf2b84c668e40187817002eb8b2c6/camunda/src/main/java/com/example/camunda/JettyServerCustomizerRuntimeAuth.java#L44
But as a configurable option, it would have been 🍰
The text was updated successfully, but these errors were encountered: