Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make authentication provider a configuration option #439

Closed
datakurre opened this issue Oct 25, 2022 · 7 comments
Closed

Make authentication provider a configuration option #439

datakurre opened this issue Oct 25, 2022 · 7 comments

Comments

@datakurre
Copy link

I wanted to customize authentication to support custom JWT authentication, and had to make a volt for something that could be a configurable string.

Authentication provider is configured at

filterHolder.setInitParameter("authentication-provider", "org.camunda.bpm.engine.rest.security.auth.impl.HttpBasicAuthenticationProvider");

Overriding that was possible https://github.com/datakurre/collective.bpmproxy/blob/dd97b4f733fdf2b84c668e40187817002eb8b2c6/camunda/src/main/java/com/example/camunda/JettyServerCustomizerRuntimeAuth.java#L44

But as a configurable option, it would have been 🍰

@tobiasschaefer
Copy link
Collaborator

Hi @datakurre ,

That sounds like a sensible feature request.

Do you want to try to create pull request? To me that would have simpler than your replace logic 😀

Todo

  • add configuration option beneath camunda.webapps with default to existing behavior
  • update implementation to use configured value
  • update README.md with configuration option

@datakurre
Copy link
Author

@tobiasschaefer Thanks for those pointers! I’ll see later if I can do this 💪 Probably would have been faster to do the option in the first place 😅

tobiasschaefer added a commit to tobiasschaefer/micronaut-camunda-bpm that referenced this issue Nov 5, 2022
…gurable, e.g. "com.example.camunda.JWTAuthenticationProvider"
tobiasschaefer added a commit to tobiasschaefer/micronaut-camunda-bpm that referenced this issue Nov 5, 2022
…gurable, e.g. "com.example.camunda.JWTAuthenticationProvider"
tobiasschaefer added a commit to tobiasschaefer/micronaut-camunda-bpm that referenced this issue Nov 5, 2022
…gurable, e.g. "com.example.camunda.JWTAuthenticationProvider"
@tobiasschaefer
Copy link
Collaborator

Hey @datakurre ,

please try release 2.11.0 which has the option to configure the authentication-provider.

see configuration option camunda.rest.authentication-provider

@datakurre
Copy link
Author

@tobiasschaefer Wow! Thanks. So good I used my time to debug long poll issue instead. Will update that issue with more details soon...

@tobiasschaefer
Copy link
Collaborator

Thanks. That's team work 😀

@datakurre
Copy link
Author

Confirm that this works. Although, one must both enable basic auth and define custom provider, but it is probably safer that way.

tobiasschaefer added a commit to tobiasschaefer/micronaut-camunda-bpm that referenced this issue Nov 13, 2022
…ation-provider no longer requires basic authentication to be enabled.
@tobiasschaefer
Copy link
Collaborator

Hi @datakurre ,

good point!

IMHO if someone (you 😀) configures a custom authentication provider he should know what he is doing. I don't see a reason why basic auth should be required since it would be used anyway. Correct?

Does this PR look good to you? #448

tobiasschaefer added a commit that referenced this issue Nov 13, 2022
…ger requires basic authentication to be enabled.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants