Fix tc-copy cannot import name 'imap' #669
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbrunner
reviewed
Dec 30, 2020
Comment on lines
+38
to
+44
| if tile.content_type: | ||
| if tile.content_type.startswith("image/"): | ||
| tile.data = response.content | ||
| else: | ||
| tile.error = response.text | ||
| elif response.status_code != 200: | ||
| tile.error = "Unable to read content type {0}".format(title.content_type) |
There was a problem hiding this comment.
I don't understand why you do this change? Shouldn't just be:
Suggested change
| if tile.content_type: | |
| if tile.content_type.startswith("image/"): | |
| tile.data = response.content | |
| else: | |
| tile.error = response.text | |
| elif response.status_code != 200: | |
| tile.error = "Unable to read content type {0}".format(title.content_type) | |
| if tile.content_type and tile.content_type.startswith("image/"): | |
| tile.data = response.content | |
| else: | |
| tile.error = response.text |
There was a problem hiding this comment.
Sometimes the response has content but not content type header set so it continues failing, i tested it using openstreetmap
There was a problem hiding this comment.
Have you an example of URL that didn't returns a content-type?
There was a problem hiding this comment.
I just merge the first part, and for this I do an alternative as #673, does it look good?
There was a problem hiding this comment.
Wouldn't i it be better coding three commands, Ill make it up
This was referenced Jan 1, 2021
|
Fixed with #673 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #220