Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Document PiP #975

Open
i1u5 opened this issue Aug 21, 2023 · 2 comments
Open

[Feature Request] Document PiP #975

i1u5 opened this issue Aug 21, 2023 · 2 comments

Comments

@i1u5
Copy link

i1u5 commented Aug 21, 2023

As of Chromium v116, the documentPictureInPicture.requestWindow() method was added, which allows to embed not just the video but any element in the PiP window, this could be useful for subtitles because they stay behind when the PiP button is pressed.

I understand this is a client-side change so it will be possible to accomplish from channel custom JS, but it could still be the default behavior of the video player.

Additional info:
VideoJS demo by Chrome devs (source code)
Official documentation
WICG Explainer

@calzoneman
Copy link
Owner

Hi,

It seems like this feature isn't available in Firefox; I usually try to constrain core features to things that are standardized and work across all major browsers to reduce user confusion and troubleshooting burden.

Could you explain a little more about the problem you were trying to solve by requesting this feature? There may be an alternative way to support the use case that doesn't rely on nonstandard features.

@Xaekai
Copy link
Collaborator

Xaekai commented Sep 11, 2023

I am among the people who spearheaded/promoted the existence of the dPIP work. You can rest assured that custom subtitle support in PIPs will be coming once Mozilla is onboard with the feature too.

calzone: they want a solution for this. When you activate PIP/video popout mode, layered elements like canvas generated subtitles do not come along for the ride. I agree we should wait for Firefox to support this feature as well before including it in core.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants