Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library queues don't preserve raw file title #935

Open
Xaekai opened this issue Mar 27, 2022 · 1 comment
Open

Library queues don't preserve raw file title #935

Xaekai opened this issue Mar 27, 2022 · 1 comment

Comments

@Xaekai
Copy link
Collaborator

Xaekai commented Mar 27, 2022

When queuing an item from a channels saved videos, and that item is a raw file that was given a custom title, that title is not used when queuing from the search interface.

@calzoneman
Copy link
Owner

calzoneman commented Mar 27, 2022

This is because search queues secretly just re-fetch the metadata instead of reusing the saved result (the saved info is only used to display those search results). Commit: c152a19

I guess losing custom titles is an unfortunate side-effect of this. It'd be a little subtle to make this work as expected: if the file actually has the proper title tags embedded in it, then I think the expected behavior would be to take the title from those tags, not the one from the saved library (including if they are different), the only reason to use the one from the library would be if the one in the library was overridden during queueing and the re-processing of the video yields no title.

I'm not really sure if it is worth it to fix this edge case when there are preferable alternatives to ensuring the title is represented correctly:

  1. Using ffmpeg -metadata title="A Cool Video" when encoding, in which case CyTube will detect the title correctly for raw files
  2. Using custom manifests, which ensure that any overrides/customizations to the metadata are explicitly modeled in a resource accessible via a single identifying URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants