Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Repeat/loop option #914

Open
vrchmvgx opened this issue Jul 21, 2021 · 2 comments
Open

[Feature] Repeat/loop option #914

vrchmvgx opened this issue Jul 21, 2021 · 2 comments

Comments

@vrchmvgx
Copy link

FEATURE REQUEST: Repeating videos

Please confirm whether you've tried the following debugging steps:

N/A

Description of the Problem

  • We use cytube to manage music playlists for tabletop RPG sessions
  • Often, songs/videos are too short that the DM must either interrupt themselves to restart tracks or queue up several instances
  • A repeat option to repeat the currently playing track does not, on surface level, sound like a major addition but would be very useful for usecases like ours

System Information

N/A

@calzoneman
Copy link
Owner

If you uncheck "Add as temporary" when adding a video, or if you later click the "make permanent" button, the video will not be removed from the playlist after playing, and the playlist will loop. Is that what you meant?

@vrchmvgx
Copy link
Author

vrchmvgx commented Jul 22, 2021

Ah, no, we do that. I'm referring more to, when having a playlist of multiple tracks, having the ability to "repeat one", that is, when video 5 ends, set the next video to 5 again if the loop button is on.

(I am extremely not good at JS, and don't know your codebase, but in essence I'm suggesting/requesting a toggle between next_video_index = current_video_index + 1 % list_length and next_video_index = current_video_index)

E:

var next = this.current.next || this.items.first;

So basically, the result if repeat/loop is on would be just calling this.startPlayback() without any changes to this.current.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants