-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug in invalidateScripts
leading to app crash
#553
Comments
|
I suppose we could drop the caller altogether for the uniqueID, and rely on users specyfing EDIT: From my understanding, the |
This issue has been marked as stale because it has been inactive for 30 days. Please update this issue or it will be automatically closed in 14 days. |
Environment
React Native android (but I believe the bug is not specific to RN android)
Description
Calling
invalidateScripts
for a chunk is causing a crash when next attempting to use that chunk. On debugging it, the chunk file is getting deleted, but the entry in sqlite db is not getting cleared. It looks like there is a bug ininvalidateScripts
method.resolveScripts
method appends caller to thescriptId
to get the cacheKey (const cacheKey = `${scriptId}_${caller ?? 'unknown'}`;
), whileinvalidateScripts
directly usesscriptId
as the cacheKey.Reproducible Demo
invalidateScripts
with that chunk's scriptIdcom.facebook.react.common.JavascriptException: ChunkLoadError: Loading chunk <scriptId> failed
The text was updated successfully, but these errors were encountered: