Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract runtime into separate package in monorepo & publish it separately #506

Open
1 task
jbroma opened this issue Feb 23, 2024 · 3 comments
Open
1 task
Labels
area:native The issue involves the native module of Re.Pack area:repack The issue is about logic/code inside of Re.Pack. help wanted especially welcoming for external contributions type:feature Proposal or idea for a new feature or enhancement.

Comments

@jbroma
Copy link
Member

jbroma commented Feb 23, 2024

Describe the feature

  • create a separate package with the Re.Pack runtime containing ScriptManager and Native Module
  • keep versioning tied to Re.Pack's version to make it easy to pick the right version
  • update docs where applicable (mainly getting started, code-splitting and module federation parts)

Motivation

Native Module of Re.Pack is only needed for code-splitting, it makes sense to make it optional. Same goes for ScriptManager. Keeping runtime of Re.Pack separate would allow for even easier switch between metro & Re.Pack as there would be no need of installing additional native dependencies on both platforms. This would also make the final app size smaller as unneeded parts would not be included in the compilation.

Related Issues

Original idea

TODO

  • Split this issue into separate tasks to make it more manageable
@jbroma jbroma added type:feature Proposal or idea for a new feature or enhancement. area:repack The issue is about logic/code inside of Re.Pack. area:native The issue involves the native module of Re.Pack help wanted especially welcoming for external contributions labels Feb 23, 2024
Copy link

This issue has been marked as stale because it has been inactive for 30 days. Please update this issue or it will be automatically closed in 14 days.

@github-actions github-actions bot added the Stale label Mar 25, 2024
Copy link

github-actions bot commented Apr 9, 2024

This issue has been automatically closed because it has been inactive for more than 14 days. Please reopen if you want to add more context.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 9, 2024
@jbroma jbroma removed the Stale label Apr 9, 2024
@jbroma jbroma reopened this Apr 9, 2024
Copy link

This issue has been marked as stale because it has been inactive for 30 days. Please update this issue or it will be automatically closed in 14 days.

@github-actions github-actions bot added the Stale label May 10, 2024
@jbroma jbroma removed the Stale label May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:native The issue involves the native module of Re.Pack area:repack The issue is about logic/code inside of Re.Pack. help wanted especially welcoming for external contributions type:feature Proposal or idea for a new feature or enhancement.
Projects
None yet
Development

No branches or pull requests

1 participant