Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI workflow & send coverage to Codecov #85

Merged
merged 9 commits into from Sep 12, 2021

Conversation

Lodin
Copy link
Collaborator

@Lodin Lodin commented Sep 1, 2021

This PR fixes CI broken in #34 and start sending code to Codecov again.

@Lodin Lodin marked this pull request as draft September 1, 2021 21:13
@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@ded7a2e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #85   +/-   ##
=======================================
  Coverage        ?   92.22%           
=======================================
  Files           ?        5           
  Lines           ?      193           
  Branches        ?       32           
=======================================
  Hits            ?      178           
  Misses          ?        4           
  Partials        ?       11           
Flag Coverage Δ
unittests 92.22% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ded7a2e...04cecec. Read the comment docs.

@Lodin Lodin marked this pull request as ready for review September 4, 2021 23:25
@calebdwilliams
Copy link
Owner

@Lodin is this ready to merge?

@Lodin
Copy link
Collaborator Author

Lodin commented Sep 5, 2021

@calebdwilliams, yep, it is.

Copy link
Owner

@calebdwilliams calebdwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@calebdwilliams calebdwilliams merged commit 34090df into calebdwilliams:main Sep 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants