Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

prisma/zod/* files get all changed after the initial setup #1791

Closed
denik1981 opened this issue Feb 10, 2022 · 7 comments
Closed

prisma/zod/* files get all changed after the initial setup #1791

denik1981 opened this issue Feb 10, 2022 · 7 comments
Labels
馃悰 bug Something isn't working

Comments

@denik1981
Copy link
Contributor

Found a bug? Please fill out the sections below. 馃憤

Issue Summary

By running yarn generate-schemas (post-installation step) all the files within the prisma/zod directory changed diffing from HEAD in a single newline missing after the first import.

Steps to Reproduce

  1. yarn generate-schemas
  2. git diff --name-only
prisma/zod/attendee.ts
prisma/zod/availability.ts
prisma/zod/booking.ts
prisma/zod/bookingreference.ts
prisma/zod/credential.ts
prisma/zod/dailyeventreference.ts
prisma/zod/attendee.ts
prisma/zod/availability.ts
prisma/zod/booking.ts
prisma/zod/bookingreference.ts
prisma/zod/credential.ts
prisma/zod/dailyeventreference.ts
prisma/zod/destinationcalendar.ts
prisma/zod/eventtype.ts
prisma/zod/eventtypecustominput.ts
prisma/zod/membership.ts
prisma/zod/payment.ts
prisma/zod/remindermail.ts
prisma/zod/resetpasswordrequest.ts
prisma/zod/schedule.ts
prisma/zod/selectedcalendar.ts
prisma/zod/team.ts
prisma/zod/user.ts
prisma/zod/verificationrequest.ts
prisma/zod/webhook.ts

Any other relevant information. For example, why do you consider this a bug and what did you expect to happen instead?

Technical details

  • node v14.19.0
  • yarn v1.22.17
  • git v2.35.1
@denik1981 denik1981 added the 馃悰 bug Something isn't working label Feb 10, 2022
@miguelnietoa
Copy link
Contributor

Yeah, the same happens to me

@denik1981
Copy link
Contributor Author

Don't worry. I have fixed it in a PR (which I'm preparing) but I have to submit the linked issue first.

@miguelnietoa
Copy link
Contributor

Don't worry. I have fixed it in a PR (which I'm preparing) but I have to submit the linked issue first.

Nice! 馃殌馃殌

@denik1981
Copy link
Contributor Author

Fixed in #1796

@denik1981
Copy link
Contributor Author

This issue is showing up once again but for a different reason.

I saw that in a recent PR prisma/zod/* files have been excluded from formatting (prettierignore) and now there is a mismatch between the committed and formatted version of these files and the ones that are generated by the user in the post-installation step.

Imho these files shouldn't be versioned at all. I don't see the point if they are fully built by prisma generate.
Can we add them to gitignore?

See #1823

@denik1981 denik1981 reopened this Feb 17, 2022
@zomars
Copy link
Member

zomars commented Feb 17, 2022

Solved in #1896

Imho these files shouldn't be versioned at all. I don't see the point if they are fully built by prisma generate.
Can we add them to gitignore?

The idea is to track changes of these files as prisma.schema gets modified. That's the main reason they're prettier ignored.

@denik1981
Copy link
Contributor Author

denik1981 commented Feb 17, 2022

Thanks for the fast fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃悰 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants