We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sometimes we make model changes and forget to generate a new migration, e.g. with the case of #2078 and the follow-up #2086.
Let's create a PR check that runs the bin/makemigrations.sh script and errors if there are pending migrations.
bin/makemigrations.sh
When a migration is needed, the output looks like:
$ bin/makemigrations.sh Migrations for 'core': benefits/core/migrations/NNNN_changes.py - [description of changes]
When there are no pending migrations, the output looks like:
$ bin/makemigrations.sh No changes detected
benefits/
No changes detected
The text was updated successfully, but these errors were encountered:
The workflow is added as a required check to merge PRs
Need to configure this once it is available in Settings
Sorry, something went wrong.
I added this as a required check for dev, test, and prod.
dev
test
prod
I forgot, if we have a required check that only runs sometimes (e.g. because of a path filter on the PR files) then that check will block some PRs.
I think to simplify we can just remove the path filter in the workflow. This check shouldn't take very long comparatively.
angela-tran
Successfully merging a pull request may close this issue.
Sometimes we make model changes and forget to generate a new migration, e.g. with the case of #2078 and the follow-up #2086.
Let's create a PR check that runs the
bin/makemigrations.sh
script and errors if there are pending migrations.When a migration is needed, the output looks like:
When there are no pending migrations, the output looks like:
Acceptance Criteria
benefits/
directorybin/makemigrations.sh
No changes detected
, the workflow failsThe text was updated successfully, but these errors were encountered: