make default PKs for mysql unsigned by default #1899
Merged
+31
−30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1780
This changes it so that the default PK for a table (either by not specifying one at all, or just setting the
id
option for the table) is unsigned by default, instead of signed. This gives users extra space to store IDs in their databases, and is generally considered the "right" definition to have for an auto incrementing column for mysql, with some amount of other ORM / DB stuff out there doing this as well.The principle downside is that foreign key columns will have to be specified with
"signed" => false
now, but I think is balanced out by the upsides of doing this.