Set column null by default unless identity #1872
Merged
+73
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
…o column_null_default
MasterOdin
changed the title
Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
|
Sounds good to me. Most will always mention the null topic explicitly anyway in their migrations. |
|
#1718 🏓 |
|
Looks like you missed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1817
This makes it so that newly added columns are
NULLby default, instead ofNOT NULLexcept in the case of a column that uses theidentityoption, and does not also set anulloption.This is definitely BC breaking, and the release notes should make a big note that all previously written migrations will have to be updated to take into account the new null default, unless the authors were already explicit about the null status within their migrations.