Configuring Connection with Driver instance legacy but not deprecated

[othercorey]

Description

https://github.com/cakephp/cakephp/blob/5.x/src/Database/Connection.php#L139-L147

In Connection::createDrivers(), passing in a Driver instance is marked legacy, but this config path was not marked deprecated in 5.0.

Is this still considered legacy and should it be deprecated?

if (!is_string($driver)) {
    assert($driver instanceof Driver);
    if (!$driver->enabled()) {
        throw new MissingExtensionException(['driver' => get_class($driver), 'name' => $this->configName()]);
    }

    // Legacy support for setting instance instead of driver class
    return [self::ROLE_READ => $driver, self::ROLE_WRITE => $driver];
}

CakePHP Version

5.0

PHP Version

No response

[othercorey]

CakePHP 4 had Connection::setDriver() which might be a part of this support.

https://github.com/cakephp/cakephp/blob/4.x/src/Database/Connection.php#L251

We dropped setDriver() in 5.0.

[ADmad]

I am pretty sure the setDriver() was primarily for testing and doesn't have an actual use case.

[markstory]

Is this still considered legacy and should it be deprecated?

I would say yes. I can't think of any scenarios in the framework where we need to pass driver instances in.