Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test using 22.04 again #16650

Merged
merged 3 commits into from Aug 5, 2022
Merged

Test using 22.04 again #16650

merged 3 commits into from Aug 5, 2022

Conversation

markstory
Copy link
Member

Locally using 22.04 + PHP 8.1 + OpenSSL 3 I don't get the error we were getting in CI previously. Trying this again to see if this problem has been resolved by changes in PHP and OpenSSL.

Locally using 22.04 + PHP 8.1 + OpenSSL 3 I don't get the error we
were getting in CI previously. Trying this again to see if this problem
has been resolved by changes in PHP and OpenSSL.
@markstory markstory added this to the 4.4.3 milestone Jul 25, 2022
Ubuntu 22.04 comes with OpenSSL 3, and the specific version that PHP is
built against has a bug which has since been fixed but isn't showing up
in the images that GitHub has available.

See openssl/openssl#18574
and php/php-src#8369
@markstory
Copy link
Member Author

@othercorey This is passing now (with a skip for the bad SSL test). Should we merge it?

@othercorey
Copy link
Member

@othercorey This is passing now (with a skip for the bad SSL test). Should we merge it?

We could. 22.04 is still in beta. Could wait until it's released to switch.

@markstory markstory modified the milestones: 4.4.3, 4.4.4 Jul 27, 2022
@othercorey
Copy link
Member

othercorey commented Aug 5, 2022

Tested with Ubuntu 22.04 release and the problem still exists.

Would be nice to know if this was a github actions virtual environment only issue, but I can't test ubuntu 22.04 right now. Unfortunately, I don't know of a clean way to skip it only for github action builds.

@othercorey othercorey merged commit f8ebddf into 4.x Aug 5, 2022
@othercorey othercorey deleted the ubuntu-2204 branch August 5, 2022 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants