Ignore limit if no order exists when building subquery #16008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
othercorey
force-pushed
the
othercorey-patch-1
branch
from
5492061
to
69fe85b
Compare
othercorey
commented
Oct 5, 2021
| if (in_array($result->name, ['mariano', 'lary'])) { | ||
| $this->assertNotEmpty($result->articles); | ||
| } else { | ||
| $this->assertEmpty($result->articles); |
There was a problem hiding this comment.
This depends on the db since there is no order. Hard to force a result in the middle of these unit tests.
|
This doesn't fail without the fix. Not sure I can create a scenario that always tests this. |
markstory
reviewed
Oct 6, 2021
| ->contain('Articles') | ||
| ->first(); | ||
|
|
||
| if (in_array($result->name, ['mariano', 'lary'])) { |
There was a problem hiding this comment.
Good catch. Still can't get it to fail in unit test.
othercorey
force-pushed
the
othercorey-patch-1
branch
from
69fe85b
to
bb54185
Compare
othercorey
force-pushed
the
othercorey-patch-1
branch
from
bb54185
to
8881d96
Compare
|
Any ideas for consistent unit tests or should we just commit and know it works? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14480