Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add actual methods to interfaces instead of @method tags. #12094

Closed
6 of 8 tasks
ADmad opened this issue May 17, 2018 · 3 comments
Closed
6 of 8 tasks

Add actual methods to interfaces instead of @method tags. #12094

ADmad opened this issue May 17, 2018 · 3 comments
Labels
deprecations enhancement
Milestone
4.0.0

Comments

@ADmad
Copy link
Member

ADmad commented May 17, 2018 •
edited by jeremyharris

Tracking issue for interfaces that should be updated in 4.x

  • ConnectionInterface
  • EntityInterface
  • InvalidPropertyInterface
  • QueryInterface
  • RepositoryInterface
  • EventDispatcherInterface
  • LocatorInterface
  • ContextInterface
@ADmad ADmad added this to the 4.0.0 milestone May 17, 2018
This was referenced May 18, 2018
Merged
Merged
Merged
@saeideng saeideng mentioned this issue May 22, 2018
Merged
This was referenced May 25, 2018
Merged
Merged
@jeremyharris jeremyharris mentioned this issue Jun 11, 2018
Merged
This was referenced Feb 20, 2019
Closed
Closed
@dereuromark
Copy link
Member

Are the remaining ones still doable? Or do we have to keep them out of the interface(s)?

@ADmad
Copy link
Member Author

ADmad commented Sep 4, 2019

I am pretty sure all possible changes are done. Remaining ones we'll just have to keep.

@ADmad ADmad closed this as completed Sep 4, 2019
@ADmad
Copy link
Member Author

ADmad commented Sep 4, 2019 •
edited

This reminds me, Entity has couple of method (maybe more) getOriginal(), getOriginalValues() values which aren't present in EntityInterface.

@ADmad ADmad reopened this Sep 4, 2019
@ADmad ADmad mentioned this issue Sep 25, 2019
Merged
@ADmad ADmad closed this as completed Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
deprecations enhancement
Projects
None yet
Milestone
4.0.0
Development

No branches or pull requests
3 participants
@markstory @dereuromark @ADmad