Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cake 5 CS #368

Open
dereuromark opened this issue Dec 27, 2022 · 1 comment
Open

Cake 5 CS #368

dereuromark opened this issue Dec 27, 2022 · 1 comment
Labels

Comments

@dereuromark
Copy link
Member

I see that current Cake5 sniffer version is still 7.2+
It seems to work with union types and other PHP 8+ topics, but still is PHP 7

Is there any plan to make the new major that is working with Cake5 and PHP 8 also tailored for it?
Or will it also be suitable for previous Cake versions etc?

I am asking, because if we tailor it to PHP 8+, we can also further include specific 8+ enhancements, e.g.

    <rule ref="SlevomatCodingStandard.Functions.RequireTrailingCommaInDeclaration"/>
    <rule ref="SlevomatCodingStandard.Functions.RequireTrailingCommaInClosureUse"/>

which improve diffing

Amonst a few other sniffs.

@ADmad
Copy link
Member

ADmad commented Dec 27, 2022

Probably an oversight, v5 of the code-sniffer should be PHP 8.1+.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants