Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitLab CI runner tags are not split correctly #4030

Closed
2 tasks done
gitfool opened this issue Oct 29, 2022 · 1 comment · Fixed by #4031
Closed
2 tasks done

GitLab CI runner tags are not split correctly #4030

gitfool opened this issue Oct 29, 2022 · 1 comment · Fixed by #4031
Labels
Milestone

Comments

@gitfool
Copy link
Contributor

gitfool commented Oct 29, 2022

Prerequisites

  • I have written a descriptive issue title
  • I have searched issues to ensure it has not already been reported

Cake runner

Cake .NET Tool

Cake version

2.3.0

Operating system

Linux

Operating system architecture

64-Bit

CI Server

GitLab CI

What are you seeing?

I noticed GitLab CI runner tags are not split correctly while playing around with gitfool/GitLabCI.Dungeon, as shown this job, the CI_RUNNER_TAGS environment variable contains brackets and quotes:

CI_RUNNER_TAGS=["gce", "east-c", "linux", "ruby", "mysql", "postgres", "mongo", "git-annex", "shared", "docker", "saas-linux-small-amd64"]

which is split into a string array that still has these brackets and quotes:

BuildSystem.GitLabCI.Environment.Runner.Tags[0]               ["gce"
BuildSystem.GitLabCI.Environment.Runner.Tags[1]               "east-c"
BuildSystem.GitLabCI.Environment.Runner.Tags[2]               "linux"
BuildSystem.GitLabCI.Environment.Runner.Tags[3]               "ruby"
BuildSystem.GitLabCI.Environment.Runner.Tags[4]               "mysql"
BuildSystem.GitLabCI.Environment.Runner.Tags[5]               "postgres"
BuildSystem.GitLabCI.Environment.Runner.Tags[6]               "mongo"
BuildSystem.GitLabCI.Environment.Runner.Tags[7]               "git-annex"
BuildSystem.GitLabCI.Environment.Runner.Tags[8]               "shared"
BuildSystem.GitLabCI.Environment.Runner.Tags[9]               "docker"
BuildSystem.GitLabCI.Environment.Runner.Tags[10]              "saas-linux-small-amd64"]

What is expected?

The runner tags should be split into a string array that strips these brackets and quotes:

BuildSystem.GitLabCI.Environment.Runner.Tags[0]               gce
BuildSystem.GitLabCI.Environment.Runner.Tags[1]               east-c
BuildSystem.GitLabCI.Environment.Runner.Tags[2]               linux
BuildSystem.GitLabCI.Environment.Runner.Tags[3]               ruby
BuildSystem.GitLabCI.Environment.Runner.Tags[4]               mysql
BuildSystem.GitLabCI.Environment.Runner.Tags[5]               postgres
BuildSystem.GitLabCI.Environment.Runner.Tags[6]               mongo
BuildSystem.GitLabCI.Environment.Runner.Tags[7]               git-annex
BuildSystem.GitLabCI.Environment.Runner.Tags[8]               shared
BuildSystem.GitLabCI.Environment.Runner.Tags[9]               docker
BuildSystem.GitLabCI.Environment.Runner.Tags[10]              saas-linux-small-amd64

Steps to Reproduce

N/A.

Output log

No response

@devlead devlead added the Feature label Nov 8, 2022
@devlead devlead added this to the v3.0.0 milestone Nov 8, 2022
@devlead devlead added Bug and removed Feature labels Nov 8, 2022
@cake-build-bot
Copy link

🎉 This issue has been resolved in version v3.0.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants