Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename WindowsFact to WindowsFactAttribute to follow best practices #3867

Closed
devlead opened this issue Apr 14, 2022 · 1 comment · Fixed by #3988
Closed

Rename WindowsFact to WindowsFactAttribute to follow best practices #3867

devlead opened this issue Apr 14, 2022 · 1 comment · Fixed by #3988
Labels
Breaking change
Milestone
v3.0.0

Comments

@devlead
Copy link
Member

devlead commented Apr 14, 2022

cake/src/Cake.Testing.Xunit/WindowsFact.cs

Line 11 in fdb906a

public sealed class WindowsFact : FactAttribute

@devlead devlead added this to the v3.0.0 milestone Apr 14, 2022
@ivanbibik ivanbibik mentioned this issue Oct 7, 2022
Closed
@ivanbibik ivanbibik mentioned this issue Oct 17, 2022
Merged
devlead added a commit that referenced this issue Oct 17, 2022
@devlead
Merge pull request #3988 from ivanbibik/3867
7c2b3b2 
#3867 Rename attribute WindowsFact-> WindowsFactAttribute
@cake-build-bot
Copy link

🎉 This issue has been resolved in version v3.0.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Breaking change
Projects
None yet
Milestone
v3.0.0
2 participants
@devlead @cake-build-bot