GH-2314: Allow setting MSBuild Platform using custom string #3221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
augustoproiete
force-pushed
the
allow-msbuild-platform-custom-string
branch
2 times, most recently
from
ec23ae6
to
946b3a4
Compare
bjorkstromm
approved these changes
Mar 3, 2021
augustoproiete
force-pushed
the
allow-msbuild-platform-custom-string
branch
from
946b3a4
to
6b24caf
Compare
augustoproiete
force-pushed
the
allow-msbuild-platform-custom-string
branch
from
6b24caf
to
351f49d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
MSBuildSettingsextensionSetPlatformTargetexpects a valid value from the PlatformTarget enumeration.This PR adds an overload which accepts a custom string.
The current workaround without this PR is to either use
.WithProperty("Platform", "...")instead ofSetPlatformTarget, or useArgumentCustomizationCloses #2314