Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH3216: Remap NuGetLogger Verbose/Verbose to ICakeLog Debug/Diagnostic #3217

Merged
merged 1 commit into from Mar 3, 2021
Merged

GH3216: Remap NuGetLogger Verbose/Verbose to ICakeLog Debug/Diagnostic #3217

merged 1 commit into from Mar 3, 2021

Conversation

gitfool
Copy link
Contributor

@gitfool gitfool commented Mar 1, 2021

Fixes #3216.

@gitfool
Copy link
Contributor Author

gitfool commented Mar 3, 2021

Unrelated build failure on ubuntu-latest which looks to be because "latest" has finally switched to Ubuntu 20.04!

This is good news but need to be using the latest GitVersion for it to be compatible.

@gitfool
Copy link
Contributor Author

gitfool commented Mar 3, 2021

And of course Bitrise still fails with the latest GitVersion. 😞

@gitfool
Copy link
Contributor Author

gitfool commented Mar 3, 2021

I see two options:

  • Use ubuntu-18.04 label to pin Ubuntu runner to 18.04
  • Fix ongoing issue with Bitrise builds using latest GitVersion (pref)

Hopefully this doesn't hold up accepting this PR as I was hoping to squeeze it into Cake 1.1.0. 😛

@augustoproiete
Copy link
Member

Thanks for looking into this @gitfool ! We're going to pin Ubuntu to 18.04 for now so we can unblock merging PRs, and revisit after we can make Bitrise work with the latest GitVersion.

We'd like to merge this PR today, so I'll remove your latest commit that updates GitVersion and rebase on top of develop once #3229 has been merged

@augustoproiete augustoproiete self-requested a review March 3, 2021 15:00
augustoproiete
augustoproiete approved these changes Mar 3, 2021
View reviewed changes
Copy link
Member

@augustoproiete augustoproiete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@augustoproiete augustoproiete merged commit 576f4b5 into cake-build:develop Mar 3, 2021
@augustoproiete
Copy link
Member

@gitfool your changes have been merged, thanks for your contribution 👍

@gitfool gitfool deleted the gh3216 branch March 3, 2021 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@augustoproiete augustoproiete augustoproiete approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remap NuGetLogger Verbose/Verbose to ICakeLog Debug/Diagnostic
2 participants
@gitfool @augustoproiete