Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add iconUrl fallback to Cake and Cake.CoreCLR packages #3213

Closed
augustoproiete opened this issue Feb 28, 2021 · 5 comments · Fixed by #3214
Closed

Add iconUrl fallback to Cake and Cake.CoreCLR packages #3213

augustoproiete opened this issue Feb 28, 2021 · 5 comments · Fixed by #3214
Assignees
@augustoproiete
Labels
Improvement
Milestone
v1.1.0

Comments

@augustoproiete
Copy link
Member

The Cake and Cake.CoreCLR packages have an embedded icon, but don't have the iconUrl set, which means that clients that don't support the embedded icon don't have an icon to fallback to, and display the default NuGet icon.
@augustoproiete augustoproiete added this to the v1.1.0 milestone Feb 28, 2021
@augustoproiete augustoproiete self-assigned this Feb 28, 2021
augustoproiete added a commit to augustoproiete-forks/cake-build--cake that referenced this issue Feb 28, 2021
@augustoproiete
(cake-buildGH-3213) Add iconUrl fallback to Cake and Cake.CoreCLR NuG…
3c2100b 
…et packages
@augustoproiete augustoproiete mentioned this issue Feb 28, 2021
Merged
devlead added a commit that referenced this issue Mar 1, 2021
@devlead
Merge pull request #3214 from augustoproiete-forks/add-icon-url-to-pa…
ded2f34 
…ckages

GH-3213: Add iconUrl fallback to Cake and Cake.CoreCLR NuGet packages
@Jericho
Copy link
Contributor

Jericho commented Mar 1, 2021

I see the PR has already been merged so I may be too late but the recommendation for icon url is https://cdn.jsdelivr.net/gh/cake-contrib/graphics/png/cake-contrib-medium.png rather than the raw.githubusercontent.com.

@augustoproiete
Copy link
Member Author

augustoproiete commented Mar 1, 2021 •
edited

I copied from Cake.Portable, so I'll blame @gep13 👀 😜

@augustoproiete
Copy link
Member Author

@Jericho https://cdn.jsdelivr.net/gh/cake-contrib/graphics/png/cake-contrib-medium.png is for Cake-Contrib logo though. Is there an equivalent for the Cake logo?

@Jericho
Copy link
Contributor

Jericho commented Mar 1, 2021

Yes there is: https://cdn.jsdelivr.net/gh/cake-build/graphics/png/cake-medium.png

This was referenced Mar 2, 2021
Closed
Merged
@cake-build-bot
Copy link

🎉 This issue has been resolved in version v1.1.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@augustoproiete augustoproiete

Labels
Improvement
Projects
None yet
Milestone
v1.1.0
3 participants
@Jericho @augustoproiete @cake-build-bot