GH-3144: TeamCityPullRequestInfo without GIT_BRANCH #3145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlythMeister
force-pushed
the
TeamCityIsPr
branch
2 times, most recently
from
3a4ed40
to
3e28e0a
Compare
augustoproiete
force-pushed
the
TeamCityIsPr
branch
from
3e28e0a
to
f747e7b
Compare
augustoproiete
changed the title
augustoproiete
force-pushed
the
TeamCityIsPr
branch
from
f747e7b
to
919dac6
Compare
augustoproiete
force-pushed
the
TeamCityIsPr
branch
from
919dac6
to
9e9aecb
Compare
|
@BlythMeister your changes have been merged, thanks for your contribution 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends #3113 and adds a fix for #3144 to use the configuration property
vcsroot.branchif theGIT_BRANCHenvironment variable does not exist.I have raised this as a seperate pull request so if there is any issue/contention with the change it doesn't hold up the original PR.
This has all commits in #3113 with 1 additional commit added 3e28e0aeca739f2b7927d5a1f6409224026b687d
Fixes #2967
Fixes #3144