Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OutputDirectory property for Chocolatey Aliases #1146

Closed
gep13 opened this issue Aug 10, 2016 · 7 comments · Fixed by #4051
Closed

Add OutputDirectory property for Chocolatey Aliases #1146

gep13 opened this issue Aug 10, 2016 · 7 comments · Fixed by #4051
Assignees
Labels
Milestone

Comments

@gep13
Copy link
Member

gep13 commented Aug 10, 2016

Once 0.10.0 is released:

chocolatey/choco#598 (comment)

@gep13 gep13 added the Feature label Aug 10, 2016
@gep13 gep13 self-assigned this Aug 10, 2016
@pascalberger
Copy link
Member

@gep13 This seems like a duplicate of #510 which was fixed with b918397

@gep13
Copy link
Member Author

gep13 commented May 5, 2017

@pascalberger yes and no.

That commit is really tricking chocolatey into thinking that it is running in the specified output directory, hence, that is where the output file goes.

Now in the chocolatey client there is an option to specify the output directory. The chocolatey aliases within Cake should correctly use that setting.

@gep13
Copy link
Member Author

gep13 commented May 5, 2017

i.e. within the ChocolateyPackRunner, set the --outputdirectory command line option.

@pascalberger
Copy link
Member

@gep13 Ah, missed this :)

I can create a PR for this. Can we expect users to have Chocolatey >= 0.10.0 installed?

@gep13
Copy link
Member Author

gep13 commented May 5, 2017

@pascalberger that is a difficult one.

The stance I personally take on this is that the aliases should work against the current latest version of the underlying tool, however, we should probably do a check in this instance to make sure that the version is high enough before attempting to run that command.

Or, I wonder, would an earlier version of chocolatey just ignore it? Perhaps worth a quick investigation.

@Roemer
Copy link
Contributor

Roemer commented Jun 1, 2017

Any news on this?

gep13 added a commit to gep13/cake that referenced this issue Nov 7, 2022
- Make use of full option name
- Make sure to always use = in option value
- Add common options to all commands
- Add new options that have been added since aliases first created
gep13 added a commit to gep13/cake that referenced this issue Nov 7, 2022
- Make use of full option name
- Make sure to always use = in option value
- Add common options to all commands
- Add new options that have been added since aliases first created
@devlead devlead added this to the v3.0.0 milestone Nov 7, 2022
@cake-build-bot
Copy link

🎉 This issue has been resolved in version v3.0.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants