Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider using goversioninfo to embed info on Windows binaries #152

Open
francislavoie opened this issue Sep 30, 2023 · 1 comment · May be fixed by #184
Open

Consider using goversioninfo to embed info on Windows binaries #152

francislavoie opened this issue Sep 30, 2023 · 1 comment · May be fixed by #184
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@francislavoie
Copy link
Member

We had a user on the forums confused as to what version of Caddy they downloaded because they didn't see a version number in the properties of the .exe file.

See https://github.com/josephspurrier/goversioninfo, we can probably use that to embed version info and a link to the docs, I guess. Ideally it just works automatically without any user input when GOOS is windows.
@francislavoie francislavoie added enhancement New feature or request good first issue Good for newcomers labels Sep 30, 2023
@mholt
Copy link
Member

mholt commented Sep 30, 2023

Neat, ok, that might be possible. Thanks!

@WeidiDeng WeidiDeng linked a pull request May 10, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

embed icon and version information to windows builds WeidiDeng/xcaddy
2 participants
@mholt @francislavoie