Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider forking go-crossplane as base for custom lexer #27

Open
emansom opened this issue Jul 18, 2022 · 1 comment
Open

Consider forking go-crossplane as base for custom lexer #27

emansom opened this issue Jul 18, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@emansom
Copy link

emansom commented Jul 18, 2022

NGIИX Inc. ™️ developed crossplane a while back to programmatically parse and build up NGIИX configuration files. @aluttik then ported this to Golang.

Consider adopting this library and/or forking it if necessary, as an effort to reduce duplication and allow adoption of the lexer across multiple projects.

@mholt mholt added the enhancement New feature or request label Jul 18, 2022
@mohammed90
Copy link
Member

mohammed90 commented Jul 19, 2022

I don't mind outsourcing the lexing/parsing to a well-tested library, especially that crossplane was their answer to programmable config. Making crossplane part of the adapter could make migration easier for NGINX users who rely on crossplane. However, is it commonly used? The NGINX crossplane repo hasn't been updated since August 2020, and the aluttik/go-crossplane hasn't been updated since May 2021, both of which have open issues and PRs.

For reference, I found this document while googling crossplane: https://www.nginx.com/wp-content/uploads/2018/12/NGINX-Conf-2018-slides_Hulegaard-config-analysis.pdf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants