Caddy shows "ResponseWriter doesn't implement http.Flusher" when enable access log and connect to a proxy server using HTTP/2 #107
Comments
|
Ah yeah, sorry about this. We didn't know this would be a breaking change, as Go recently introduced the |
|
Replace type-asserting to ResponseController simply, Caddy doesn't log "ResponseWriter doesn't implement http.Flusher" error, but still can't connected to website througth HTTPS proxy server. --- old/forwardproxy/forwardproxy.go 2023-08-18 16:29:35.315551349 +0800
+++ new/forwardproxy/forwardproxy.go 2023-08-18 16:27:56.808116573 +0800
@@ -309,13 +309,12 @@ func (h *Handler) ServeHTTP(w http.Respo
fallthrough
case 3:
defer r.Body.Close()
- wFlusher, ok := w.(http.Flusher)
- if !ok {
- return caddyhttp.Error(http.StatusInternalServerError,
- fmt.Errorf("ResponseWriter doesn't implement http.Flusher"))
- }
+ wController := http.NewResponseController(w)
w.WriteHeader(http.StatusOK)
- wFlusher.Flush()
+ err := wController.Flush()
+ if err != nil {
+ return caddyhttp.Error(http.StatusInternalServerError, fmt.Errorf(err.Error()))
+ }
return dualStream(targetConn, r.Body, w)
} |
Merged
4 tasks
Merged
|
Should be fixed after #74. |
|
@jerry-wolf Do you want to try again now with the latest commits? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1. Is bug reproducible with latest
forwardproxybuild?2. What are you trying to do?
Run a forward proxy, and log request info (remote_ip, host, timestamp, etc).
3. What is your entire Caddyfile?
4. How is your client configured?
chrome --proxy-server=https://example.com5. How did you run Caddy? (give the full command and describe the execution environment). If multiple servers are used (for example with
upstream), describe those as well.Ubuntu 22.04.
systemctl start caddyInstalled following [this article](Installed following this article fragment), and use xcaddy to build custom caddy.
Here is build info:
6. Please paste any relevant HTTP request(s) here.
{"level":"error","ts":1692210036.1514633,"logger":"http.log.access.log0","msg":"handled request","request":{"remote_ip":"*.*.*.*","remote_port":"32362","client_ip":"*.*.*.*","proto":"HTTP/2.0","method":"CONNECT","host":"www.google.com:443","uri":"www.google.com:443","headers":{"User-Agent":["Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/117.0.0.0 Safari/537.36"]},"tls":{"resumed":false,"version":772,"cipher_suite":4865,"proto":"h2","server_name":"example.com"}},"bytes_read":0,"user_id":"","duration":0.051599699,"size":0,"status":500,"resp_headers":{"Server":["Caddy"],"Alt-Svc":["h3=\":8443\"; ma=2592000"]}}7. What did you expect to see?
Connected to website througth HTTPS proxy server.
8. What did you see instead (give full error messages and/or log)?
Chrome shows ERR_TUNNEL_CONNECTION_FAILED.
Server log:
{"level":"error","ts":1692210036.1514091,"logger":"http.log.error.log0","msg":"ResponseWriter doesn't implement http.Flusher","request":{"remote_ip":"*.*.*.*","remote_port":"32362","client_ip":"*.*.*.*","proto":"HTTP/2.0","method":"CONNECT","host":"www.google.com:443","uri":"www.google.com:443","headers":{"User-Agent":["Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/117.0.0.0 Safari/537.36"]},"tls":{"resumed":false,"version":772,"cipher_suite":4865,"proto":"h2","server_name":"example.com"}},"duration":0.051599699,"status":500,"err_id":"a8v3vpdmf","err_trace":"forwardproxy.(*Handler).ServeHTTP (forwardproxy.go:314)"}9. How can someone who is starting from scratch reproduce the bug as minimally as possible?
Make sure to use HTTP/2 to connect to the proxy server. Make sure to use the log directive in the site block. Maybe it's easier to reproduce using a non-default port.
The text was updated successfully, but these errors were encountered: