Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set EDNS0 to 1232 bytes per recommendation #188

Merged
merged 1 commit into from May 29, 2022

Conversation

Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mohammed for the research. Let's give it a try

@mholt mholt merged commit d08f6e1 into caddyserver:master May 29, 2022
@mohammed90 mohammed90 deleted the edns0-1232 branch May 29, 2022 20:58
@francislavoie
Copy link
Member

Maybe we can get rid of this when we bump minimum to Go 1.19 btw (or do we get it for free by building on 1.19?)

@mholt
Copy link
Member

mholt commented Aug 2, 2022

I'm guessing that since we're doing our own resolver, we won't get this patch for free just by using Go 1.19; we'd probably get it if we had Go do the lookups for us. But I'd have to read more into it to be sure.

@mohammed90
Copy link
Member Author

Matt is right. We're using github.com/miekg/dns here, not Go's DNS resolver. Miek's package does its own resolution and not rely on stdlib except for shuttling the net bytes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants