Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite: Add method Caddyfile directive #4528

Merged
merged 1 commit into from Jan 18, 2022
Merged

rewrite: Add method Caddyfile directive #4528

merged 1 commit into from Jan 18, 2022

Conversation

francislavoie
Copy link
Member

Fixes #4523

Pretty simple. The order of this directive is up for debate though. Just went with what feels intuitive to me, but it's hard to say for sure how this will be used in combination with other directives.

@francislavoie francislavoie added feature ⚙️ New feature or request under review 🧐 Review is pending before merging labels Jan 17, 2022
@francislavoie francislavoie added this to the v2.5.0 milestone Jan 17, 2022
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- this is exactly how I would have done it I think. Thanks!

@mholt mholt removed the under review 🧐 Review is pending before merging label Jan 18, 2022
@mholt mholt merged commit bcb7a19 into master Jan 18, 2022
@mholt mholt deleted the method-caddyfile-dir branch January 18, 2022 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature ⚙️ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Add method subdirective to caddy file
2 participants