httpcaddyfile: Support configuring pki app names via global options
#4450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francislavoie
added
feature ⚙️
francislavoie
force-pushed
the
configure-pki-names
branch
from
e2df4ab
to
cd60afb
Compare
mholt
requested changes
Dec 2, 2021
francislavoie
force-pushed
the
configure-pki-names
branch
from
cd60afb
to
09d3b20
Compare
francislavoie
force-pushed
the
configure-pki-names
branch
from
09d3b20
to
5bc7933
Compare
|
@tgelite Could you please verify that this meets your needs? |
francislavoie
force-pushed
the
configure-pki-names
branch
from
5bc7933
to
7d8af08
Compare
|
Apologies, I've been offline. Yes this is addressing what is needed to
define root and intermediate CA names from the Caddyfile. Thank you.
…On Mon, Dec 13, 2021 at 1:12 PM Matt Holt ***@***.***> wrote:
@tgelite <https://github.com/tgelite> Could you please verify that this
meets your needs?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4450 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQKW6VJ7NS7POW5KI67LNYDUQZHRLANCNFSM5I5WYHWQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
--
[image: photograph]
Todd Grayson
Investor, Technical Advisor
EES LLC
m: (303) 601-9193
p: (303) 759-3144
e: ***@***.***
2175 S Jasmine St.
Suite 119
www.Elite-Env.com <http://www.elite-env.com/>
[image: facebook icon] <https://www.facebook.com/EliteEnv> [image: linkedin
icon]
<https://www.linkedin.com/company/Elite-Environmental-Solutions-LLC-CO> [image:
instagram icon] <https://www.instagram.com/EliteEnvLLC>
|
mholt
reviewed
Jan 6, 2022
mholt
approved these changes
Jan 6, 2022
francislavoie
force-pushed
the
configure-pki-names
branch
from
b1893b6
to
1800679
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4435
Pretty self explanatory, allows configuring the PKI app name and root/intermediate common names. Works alongside the existing
acme_serverdirective andskip_install_trustoptions. We could deprecate the top-levelskip_install_trustin favor of configuring it via the defaultpkiapp, but 🤷♂️ I need no reason to do that right now. This works fine.