improve fmt warning message

[hrz6976]

Closes #4416
This PR only modifies "caddy fmt" warning message. The former one may cause confusion, and this mod might save several hours for someone else.

[CLAassistant]

All committers have signed the CLA.

[mholt]

The only qualm I have with this suggestion is that caddy fmt isn't just about a consistent style, sometimes it can fix bugs in the Caddyfile, for example missing a space where one is expected. It's not required, but it's more than just a style preference.

I'm really hoping nobody spends hours trying to figure out how to run caddy fmt though, if it takes more than a minute or two, there's something else wrong I think, and I'm not sure it's this warning string.

[francislavoie]

IMO I think the warning string is confusing because it doesn't mention that caddy fmt is a command. Many users on the forums come to ask what it's about.

I think we could clarify, but I agree this PR's wording might not be the right one.

[mholt]

How about run the 'caddy fmt' command to fix formatting inconsistencies in the Caddyfile

[francislavoie]

Or maybe: Caddyfile input is not formatted; run the 'caddy fmt' command to fix inconsistencies ?

[hrz6976]

Thank you for your response to a newbie OSS developer! I think you got it right.

[hrz6976]

Sorry for my newbie question :) To clean up the commit history, I rebased this branch with the upstream head, squashed the commits, and force-pushed. But I'm not quite sure how caddy does it (I've heard that force push is discouraged by some other projects, and if it is the case, what should I do?)

[francislavoie]

We use GitHub's squash and merge button at the end usually. So it doesn't matter too much how PR authors end up organizing their branches in the end. What you did is fine 👍

[francislavoie]

Thanks!

[mholt]

Looks great, thanks!