From 6968c7e86916b5a252d72b0b6d18d163aafab0b7 Mon Sep 17 00:00:00 2001 From: Francis Lavoie Date: Fri, 19 Nov 2021 23:20:46 -0500 Subject: [PATCH] caddyhttp: Log non-500 handler errors at debug level Fixes #4428 It's best to still log handler errors at debug level so that they're hidden by default, but still accessible if additional details are necessary. --- modules/caddyhttp/server.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/modules/caddyhttp/server.go b/modules/caddyhttp/server.go index 80948325de8..26384af10ab 100644 --- a/modules/caddyhttp/server.go +++ b/modules/caddyhttp/server.go @@ -244,6 +244,8 @@ func (s *Server) ServeHTTP(w http.ResponseWriter, r *http.Request) { // successfully, so now just log the error if errStatus >= 500 { logger.Error(errMsg, errFields...) + } else { + logger.Debug(errMsg, errFields...) } } else { // well... this is awkward @@ -262,6 +264,8 @@ func (s *Server) ServeHTTP(w http.ResponseWriter, r *http.Request) { } else { if errStatus >= 500 { logger.Error(errMsg, errFields...) + } else { + logger.Debug(errMsg, errFields...) } w.WriteHeader(errStatus) }