Fix to HTTP/2.- and Chrome coalescing issue #4023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made change to return status code 421 instead of 403 when StrictSNIHost matching is on.
|
|
|
Update: I'm still not sure whether this is the right place to make this change, or if the standard lib should implement this instead since only it knows if the connection is reused. |
|
We'll close this for now, until we settle on a solution in #4017. |
mholt
approved these changes
Jan 12, 2022
|
Wow! Almost forgot about this... :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made change to return status code 421 instead of 403 when StrictSNIHost matching is on.
This is related to:
#4017
I'm not suggesting this is the complete fix. I just know it fixes a critical issue with Chrome (and presumable Firefox).