Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caddy access logs log client errors at "level": "ERROR" #6106

Closed
tgeoghegan opened this issue Feb 14, 2024 · 3 comments
Closed

Caddy access logs log client errors at "level": "ERROR" #6106

tgeoghegan opened this issue Feb 14, 2024 · 3 comments
Assignees
Labels
bug 🐞 Something isn't working
Milestone

Comments

@tgeoghegan
Copy link
Contributor

tgeoghegan commented Feb 14, 2024

Successfully serving an HTTP 404 response to a request will show up in Caddy access logs with "level": "ERROR", despite the fact that the server hasn't made any error. See this discussion thread on caddy.community for more details and discussion of some options for solutions.

@mholt mholt added the bug 🐞 Something isn't working label Feb 14, 2024
@mholt mholt self-assigned this Feb 14, 2024
@mholt
Copy link
Member

mholt commented Feb 14, 2024

What if I submit a PR for this and we can duke it out there, @francislavoie 😄

@francislavoie
Copy link
Member

@mholt that code is already being touched by a couple other PRs so there'll be merge conflicts. Probably best to wait for #6088 and #6082

@mholt mholt added this to the v2.8.0 milestone Apr 17, 2024
@mholt mholt closed this as completed in 4af38e5 May 10, 2024
@mholt
Copy link
Member

mholt commented May 10, 2024

It is a 1-line change AFAICT, so I just went ahead and did it real quick; just decided to go with INFO level for 4xx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants