Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OTEL_EXPORTER_OTLP_PROTOCOL env variable support #5743

Open
akvlad opened this issue Aug 14, 2023 · 1 comment
Open

Add OTEL_EXPORTER_OTLP_PROTOCOL env variable support #5743

akvlad opened this issue Aug 14, 2023 · 1 comment
Labels
feature ⚙️ New feature or request help wanted 🆘 Extra attention is needed

Comments

@akvlad
Copy link

akvlad commented Aug 14, 2023

In the opentelemetry documentation you have link to, there is a configuration of the protocol for traces to send: https://github.com/open-telemetry/opentelemetry-specification/blob/v1.7.0/specification/protocol/exporter.md#specify-protocol. It can be grpc or http/protobuf etc.

As far as I see in the code: https://github.com/caddyserver/caddy/blob/master/modules/caddyhttp/tracing/tracer.go#L61 you have only grpc supported.

It would be great to have other options like http/protobuf supported as well. Some tracing ingesters have the no GRPC support by different reasons.

@francislavoie
Copy link
Member

PRs welcome. Most maintainers don't use tracing or metrics ourselves, so we need to lean on the community to contribute improvements.

@francislavoie francislavoie added feature ⚙️ New feature or request help wanted 🆘 Extra attention is needed labels Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature ⚙️ New feature or request help wanted 🆘 Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants