Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapters are counted as standard modules #5621

Open
mholt opened this issue Jul 7, 2023 · 0 comments · May be fixed by #5624
Open

Adapters are counted as standard modules #5621

mholt opened this issue Jul 7, 2023 · 0 comments · May be fixed by #5624
Labels
bug 🐞 Something isn't working

Comments

@mholt
Copy link
Member

mholt commented Jul 7, 2023 •
edited

Because we use a bit of a hack to make config adapters count as modules, these plugins are incorrectly counted as "standard" (i.e. bundled into the core distribution from this repo).

Since config adapters aren't actually config modules, we should probably not count them as such.

And maybe list-modules should be list-plugins.

I dunno. Thoughts?

(Thanks to @mohammed90 for discovering.)
@mholt mholt added the bug 🐞 Something isn't working label Jul 7, 2023
@WeidiDeng WeidiDeng linked a pull request Jul 10, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐞 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cmd: Unwrap adapter modules to get underlying modules caddyserver/caddy
1 participant
@mholt