Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dynamic passive health check #4949

Open
akosyakov opened this issue Aug 10, 2022 · 2 comments · May be fixed by #5398
Open

dynamic passive health check #4949

akosyakov opened this issue Aug 10, 2022 · 2 comments · May be fixed by #5398
Labels
feature ⚙️ New feature or request

Comments

@akosyakov
Copy link

akosyakov commented Aug 10, 2022 •
edited

Is it possible to provide ratio of unhealthy request to all requests instead of unhealthy_request_count? i.e. I want to configure if >=1% of requests are unhealthy to upstream then it should be considered down.

What is the best practice of coming up with unhealthy_request_count?
@francislavoie
Copy link
Member

francislavoie commented Aug 10, 2022 •
edited

Currently, we're not keeping a count of total of successful requests for health checking, we only keep count of failed requests. So a ratio isn't possible right now. But we could add support that, I think. I'll revisit later.

@francislavoie francislavoie added the feature ⚙️ New feature or request label Aug 10, 2022
@francislavoie francislavoie linked a pull request Feb 26, 2023 that will close this issue
Draft
@francislavoie
Copy link
Member

I'm starting work on this in #5398

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature ⚙️ New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

reverseproxy: Health as a ratio of successful requests caddyserver/caddy
2 participants
@francislavoie @akosyakov