Parsing error with new protocols directive

[ueffel]

The new protocols subdirective in servers is only excepted when it is the last directive in the servers block. Is that intended?

Example Caddyfile:

{
	servers :443 {
		protocols h1 h2 h3
		strict_sni_host insecure_off
	}
}

or

{
	servers :443 {
		protocols h1 h2 h3
		log_credentials
	}
}

Produces errors:

Error: adapting config using caddyfile: parsing caddyfile tokens for 'servers': Caddyfile:4 - Error during parsing: Wrong argument count or unexpected line ending after 'strict_sni_host'

Error: adapting config using caddyfile: parsing caddyfile tokens for 'servers': Caddyfile:4 - Error during parsing: Wrong argument count or unexpected line ending after 'log_credentials'

This works though:

{
	servers :443 {
		log_credentials
		protocols h1 h2 h3
	}
}

Related pull request: #4707

Tested version: v2.6.0-beta.5

[francislavoie]

Yep, I see the issue. Thanks! Pushing a fix in a sec.

[danlsgiga]

Hey folks, just spotted this same issue but with a different directive:

NOT WORKING

{
  servers {
    metrics
    strict_sni_host insecure_off
  }
}

Error: adapting config using caddyfile: parsing caddyfile tokens for 'servers': Caddyfile:14 - Error during parsing: Wrong argument count or unexpected line ending after 'strict_sni_host'

WORKING

{
  servers {
    strict_sni_host insecure_off
    metrics
  }
}

[francislavoie]

Thanks @danlsgiga, got it 👍