Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

caddytls: Add propagation_delay, support propagation_timeout -1 #4723

Merged
merged 1 commit into from Apr 22, 2022

Conversation

francislavoie
Copy link
Member

This has been a thorn for plenty of users in situations where their configured DNS resolvers can't actually see the TXT records Caddy ends up writing, so DNS challenges fail for them.

This makes it possible to turn off propagation, but also adds a new initial delay which can be used as a replacement for for "giving the the DNS provider some time to get their things sorted".

For example, to turn of propagation checks, but still wait 30 seconds before continuing:

tls {
	issuer acme {
		propagation_delay 30s
		propagation_timeout -1
	}
}

@francislavoie francislavoie added the feature ⚙️ New feature or request label Apr 22, 2022
@francislavoie francislavoie added this to the v2.5.0 milestone Apr 22, 2022
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's get this into v2.5! Thanks Francis.

@mholt mholt merged commit 77a77c0 into master Apr 22, 2022
@francislavoie francislavoie deleted the impl-propagation-delay branch April 22, 2022 22:24
@hvisage
Copy link

hvisage commented Apr 23, 2022

Just a Quick Q: This isn't a global option, only a per domain option, correct?

@francislavoie
Copy link
Member Author

Not global. This is per-issuer config.

@hvisage
Copy link

hvisage commented Apr 23, 2022

Thank you, might be nice to have it "global", but this still works great THANK YOU!!

*.silo1.pint.ovh silo1.pint.ovh {
tls {
    issuer acme {
        dns acmedns /etc/acmedns/clientstorage.json
        propagation_delay 30s
        propagation_timeout -1
    }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature ⚙️ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants