New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Ensure we always check for latest version of Go #4703
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hol'up, doesn't work. (Discussed in Slack) -- doesn't pick up Go 1.17.9 or Go 1.18.1...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch and addition. Thanks, Francis!
4550b83
to
0af186e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I kinda hate it but hopefully it's somewhat temporary. 😅
Go
1.18.1
isn't being pulled by https://github.com/actions/setup-go right now because the versions are pulled from https://github.com/actions/go-versions and it hasn't been updated with it yetWe were incidentally using
1.17
and1.18
as our semver strings previously; if we change the matrix to use an actual semver like~1.18.1
then it actually renames the job itself, which breaks the "required job" thing in githubMac 1.18.1 isn't out yet because of "an issue" all: provide macOS downloads for Go 1.18.1 golang/go#52317 so I need to implement a hack for that too
So to keep the same labels, but customize the semver string, I'm using an
include
to write to aGO_SEMVER
variable for it, and using that as thesetup-go
version; the rest uses the short version name from the matrix.