Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Ensure we always check for latest version of Go #4703

Merged
merged 5 commits into from Apr 13, 2022
Merged

Conversation

francislavoie
Copy link
Member

@francislavoie francislavoie commented Apr 13, 2022

  • Go 1.18.1 isn't being pulled by https://github.com/actions/setup-go right now because the versions are pulled from https://github.com/actions/go-versions and it hasn't been updated with it yet

  • We were incidentally using 1.17 and 1.18 as our semver strings previously; if we change the matrix to use an actual semver like ~1.18.1 then it actually renames the job itself, which breaks the "required job" thing in github

  • Mac 1.18.1 isn't out yet because of "an issue" all: provide macOS downloads for Go 1.18.1 golang/go#52317 so I need to implement a hack for that too

  • So to keep the same labels, but customize the semver string, I'm using an include to write to a GO_SEMVER variable for it, and using that as the setup-go version; the rest uses the short version name from the matrix.

@francislavoie francislavoie added the CI/CD 🔩 Automated tests, releases label Apr 13, 2022
@mholt mholt added this to the v2.5.0 milestone Apr 13, 2022
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hol'up, doesn't work. (Discussed in Slack) -- doesn't pick up Go 1.17.9 or Go 1.18.1...

Copy link
Member

@mohammed90 mohammed90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch and addition. Thanks, Francis!

Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I kinda hate it but hopefully it's somewhat temporary. 😅

@mholt mholt merged commit c3a82f5 into master Apr 13, 2022
@mholt mholt deleted the ci-go-check-latest branch April 13, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD 🔩 Automated tests, releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants