idempotent installation #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't run the installer if Nix has already been installed on the host. We assume that the installed Nix is already in the desired state. This allows to share a given pipeline between hosted and self-hosted runners. Usually the self-hosted runners are long-lived and already have Nix installed.
|
That's mostly needed for macos right, I think linux should just work as-is. |
|
I remember the installer failing when invoked twice on Linux as well, but that was a long time ago. Another nice property is that this allows reducing the permission set of the user if Nix is already installed. Which is probably a good thing for long-running machines. |
|
Linux should be fixed in last release. Some might use the installer to install twice with different settings, but I don't think that's a good use case to support since it should just use different jobs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't run the installer if Nix has already been installed on the host.
We assume that the installed Nix is already in the desired state.
This allows to share a given pipeline between hosted and self-hosted
runners. Usually the self-hosted runners are long-lived and already have
Nix installed.